Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project feature warning (10,000) and limit (30,000) #2215

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Related to #2184
Also related to #2190, based on @Sujanadh's debugging πŸ™
Referenced in #1732

Describe this PR

A warning is displayed on the dataset upload / OSM fetch page if more than 10,000 features (the demo was set to 500 for testing in the screenshot):

Screenshot 2025-02-19 162307

An error is displayed on the dataset upload / OSM fetch page if more than 30,000 features (the demo was set to 500 for testing in the screenshot). The user is blocked from continuing:

Screenshot 2025-02-19 162242

During project creation, if there are more than 10,000 features, then the user receives a different prompt and the redirect takes 20 seconds to complete:

Screenshot 2025-02-19 171136

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@github-actions github-actions bot added enhancement New feature or request frontend Related to frontend code backend Related to backend code labels Feb 19, 2025
@spwoodcock spwoodcock self-assigned this Feb 19, 2025
@spwoodcock spwoodcock merged commit e2a8102 into development Feb 20, 2025
9 checks passed
@spwoodcock spwoodcock deleted the feat/feature-limits branch February 20, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code enhancement New feature or request frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants