fix(next): Replace toBlob() with convertToBlob() for OffscreenCanvas compatibility #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using the web worker version in Next.js projects, users encountered a persistent error:
Conversion failed: k.toBlob is not a functionThe next version (
src/next/index.js) usesOffscreenCanvasinstead of regularHTMLCanvasElementto support server-side rendering and web workers. However, the code was callingcanvas.toBlob(), which is only available onHTMLCanvasElement, not onOffscreenCanvas.Solution
Replaced
canvas.toBlob()withcanvas.convertToBlob()in theheicTofunction. TheconvertToBlob()method is the correct API forOffscreenCanvasand returns a Promise directly, allowing us to simplify the code by removing the manual Promise wrapper.Changes
File:
src/next/index.jscanvas.toBlob(callback, type, quality)wrapped in a Promisecanvas.convertToBlob({ type, quality })which returns a PromiseBenefits
k.toBlob is not a functionerror in Next.js projectsOffscreenCanvasAPI methodconvertToBlob()already returns a PromiseAdditional Updates
Testing
dist/next/heic-to.js