Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.withIdPrefix(prefix) #124

Merged
merged 8 commits into from
Mar 4, 2017
Merged

.withIdPrefix(prefix) #124

merged 8 commits into from
Mar 4, 2017

Conversation

gr2m
Copy link
Member

@gr2m gr2m commented Feb 21, 2017

closes hoodiehq/discussion#106

This PR includes a breaking change:

separate methods like require(pouchdb-hoodie-api/add) can no longer be required directly

The reason for that is that all the methods now also accept a prefix argument which by default is null. That way we don’t need to implement each method twice, once for store.add, and once for store.withIdPrefix('test/').add

@gr2m gr2m changed the base branch from master to next February 26, 2017 03:27
@gr2m gr2m force-pushed the discussion/106/with-id-prefix branch from ba35aba to 38f976e Compare February 26, 2017 03:36
@gr2m gr2m merged commit 79a837f into next Mar 4, 2017
@gr2m gr2m deleted the discussion/106/with-id-prefix branch March 4, 2017 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant