-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proof of concept for account profiles. #98
base: master
Are you sure you want to change the base?
Conversation
No I wouldn’t do that. I’d agree with I think the |
can you add a test to |
@@ -31,7 +31,7 @@ function Account (options) { | |||
update: require('./lib/update').bind(null, state), | |||
profile: { | |||
get: require('./lib/profile-get').bind(null, state), | |||
fetch: require('./lib/profile-fetch').bind(null, state, 'account.profile'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch 👍
I’d maybe add another integration test: |
@gr2m have added (server) a test here: hoodiehq/hoodie-account-server@f69ffa9 Keen on feedback before I do the PATCH test just in case :) |
Some notes on this PR:
profile
requests have been dealt to.To do:
hoodie-account-client
hoodie-account
More than happy for someone to add to this PR ;)
closes #11