Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit update event on profile change #111

Merged
merged 2 commits into from
Jul 25, 2016
Merged

Conversation

espy
Copy link
Member

@espy espy commented Jul 25, 2016

No description provided.

@varjmes
Copy link
Contributor

varjmes commented Jul 25, 2016

LGTM ✨

deskbeers

@gr2m
Copy link
Member

gr2m commented Jul 25, 2016

looking at it now

@gr2m
Copy link
Member

gr2m commented Jul 25, 2016

The account update event currently does not pass the profile property

account.on('update', function (account) {
  // account.profile is undefined
})
account.profile.update({foo: 'bar'})

It’s somewhat related to #107. Probably the simplest solution for both #107 and this PR is to always include profile everywhere. It might eventually become a performance issues with people start storing gazillions of data in account profiles, but until then we should be fine?

Any thoughts?

@gr2m
Copy link
Member

gr2m commented Jul 25, 2016

never mind, this is not affected, profile is included in the update event, LGTM! Merging

@gr2m gr2m merged commit a3eb4a9 into master Jul 25, 2016
@gr2m gr2m removed the in progress label Jul 25, 2016
@gr2m gr2m deleted the profile-update-event branch July 25, 2016 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants