Merge pull request #120 from honeycombio/jharley.bugfix-order-ascending

bugfix: 'ascending' sort order always showing diff
honeycombio · Feb 17, 2022 · bc5ef34 · bc5ef34
2 parents 20b142f + 774d572
commit bc5ef34
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/honeycombio/data_source_query_specification.go b/honeycombio/data_source_query_specification.go
@@ -422,7 +422,14 @@ func extractOrders(d *schema.ResourceData) []honeycombio.OrderSpec {
 
 		so, ok := d.GetOk(fmt.Sprintf("order.%d.order", i))
 		if ok {
-			order.Order = honeycombio.SortOrderPtr(honeycombio.SortOrder(so.(string)))
+			ov := honeycombio.SortOrder(so.(string))
+			// ascending is the default, API doesn't return or require
+			// the field unless value is descending
+			//
+			// not sending to avoid constant plan diffs
+			if ov != honeycombio.SortOrderAsc {
+				order.Order = honeycombio.SortOrderPtr(ov)
+			}
 		}
 
 		// TODO: validation

diff --git a/honeycombio/data_source_query_specification_test.go b/honeycombio/data_source_query_specification_test.go
@@ -62,7 +62,7 @@ data "honeycombio_query_specification" "test" {
     }
     order {
         column = "column_1"
-        order  = "descending"
+        order  = "ascending"
     }
 
     having {
@@ -124,8 +124,7 @@ const expectedJSON string = `{
       "column": "duration_ms"
     },
     {
-      "column": "column_1",
-      "order": "descending"
+      "column": "column_1"
     }
   ],
   "havings": [