Skip to content

Commit

Permalink
Merge pull request #226 from honeycombio/josslynz.marker-type-settings
Browse files Browse the repository at this point in the history
updated color to be a required field so it matches the api client
  • Loading branch information
josslynzhang authored Oct 3, 2022
2 parents 4061722 + bcaea30 commit 28a4922
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/resources/marker_setting.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ The following arguments are supported:

* `dataset` - (Required) The dataset this marker setting is placed on.
* `type` - (Required) The type of the marker setting, Honeycomb.io can display markers in different colors depending on their type.
* `color` - (Optional) The color set for the marker as a hex color code (e.g. `#DF4661`)
* `color` - (Required) The color set for the marker as a hex color code (e.g. `#DF4661`)

## Attribute Reference

Expand Down
2 changes: 1 addition & 1 deletion honeycombio/resource_marker_setting.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func newMarkerSetting() *schema.Resource {
},
"color": {
Type: schema.TypeString,
Optional: true,
Required: true,
ValidateFunc: validation.StringMatch(regexp.MustCompile(`^#([A-Fa-f0-9]{6}|[A-Fa-f0-9]{3})$`), "invalid color hex code"),
},
"dataset": {
Expand Down

0 comments on commit 28a4922

Please sign in to comment.