Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add AlwaysOffSampler #72

Merged
merged 2 commits into from
Feb 14, 2024
Merged

feat: add AlwaysOffSampler #72

merged 2 commits into from
Feb 14, 2024

Conversation

JamieDanielson
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Allow sample rate of 0 and don't convert to default of 1
  • Add AlwaysOffSampler to be used with sample rate of 0; drop everything.
  • Update tests

How to verify that this has the expected result

Setting a sample rate of 0 is valid and should drop all telemetry

@JamieDanielson JamieDanielson requested review from a team as code owners February 14, 2024 16:20
JamieDanielson
JamieDanielson commented Feb 14, 2024
View reviewed changes
src/util.ts Outdated Show resolved Hide resolved
@JamieDanielson JamieDanielson self-assigned this Feb 14, 2024
@JamieDanielson JamieDanielson added the type: enhancement New feature or request label Feb 14, 2024
ahrbnsn
ahrbnsn approved these changes Feb 14, 2024
View reviewed changes
src/types.ts Show resolved Hide resolved
@JamieDanielson JamieDanielson mentioned this pull request Feb 14, 2024
Closed
@JamieDanielson JamieDanielson added the version: bump minor A PR that adds behavior, but is backwards-compatible. label Feb 14, 2024
@JamieDanielson JamieDanielson merged commit 3253490 into main Feb 14, 2024
8 checks passed
@JamieDanielson JamieDanielson deleted the jamie.always-off-sampler branch February 14, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrbnsn ahrbnsn ahrbnsn approved these changes

Assignees

@JamieDanielson JamieDanielson

Labels
type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieDanielson @ahrbnsn