Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: test and local dev notes cleanup #71

Merged
merged 9 commits into from
Feb 14, 2024
Merged

maint: test and local dev notes cleanup #71

merged 9 commits into from
Feb 14, 2024

Conversation

JamieDanielson
Copy link
Contributor

Which problem is this PR solving?

  • Some messiness I caused in various places

Short description of the changes

  • add more dev docs around smoke tests and the need for bats-core and jq to run locally
  • add more dev docs around example usage and building tarballs to work with
  • remove some extra funkiness in Dockerfile and dev doc
  • rename "agent" to "sdk telemetry" in smoke test

How to verify that this has the expected result

following the steps to setup and run smoke tests locally actually works 😅

@JamieDanielson JamieDanielson requested review from a team as code owners February 13, 2024 23:53
@JamieDanielson JamieDanielson self-assigned this Feb 13, 2024
@JamieDanielson JamieDanielson mentioned this pull request Feb 13, 2024
Merged
@JamieDanielson JamieDanielson added the type: maintenance The necessary chores to keep the dust off. label Feb 13, 2024
JamieDanielson
JamieDanielson commented Feb 14, 2024
View reviewed changes
DEVELOPING.md Outdated Show resolved Hide resolved
JamieDanielson
JamieDanielson commented Feb 14, 2024
View reviewed changes
DEVELOPING.md Outdated Show resolved Hide resolved
@JamieDanielson JamieDanielson merged commit 800475a into main Feb 14, 2024
8 checks passed
@JamieDanielson JamieDanielson deleted the jamie.test-cleanup branch February 14, 2024 22:34
@JamieDanielson JamieDanielson added the version: no bump A PR with maintenance or doc changes that aren't included in a release. label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkanal pkanal pkanal approved these changes

Assignees

@JamieDanielson JamieDanielson

Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieDanielson @pkanal