Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beta update check #2363

Merged
merged 3 commits into from
Feb 23, 2025
Merged

Conversation

dnicolson
Copy link
Contributor

♻️ Current situation

This fixes the following error when updating beta versions:
"Failed to check for bundled update as Request failed with status code 404"

It's unclear if alpha, next, or test need to be inlcuded.

💡 Proposed solution

Prevent 404 errors when looking for a beta release instead of a tagged release.

This also reverts the logging change in c81fddd to improve grammar.

@github-actions github-actions bot added the latest Related to Latest Branch label Feb 22, 2025
@bwp91
Copy link
Contributor

bwp91 commented Feb 22, 2025

We should include alpha too as sometimes an alpha version is published of the UI 👍

Copy link
Contributor

@bwp91 bwp91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bwp91 bwp91 merged commit 5258f0d into homebridge:latest Feb 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
latest Related to Latest Branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants