Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace nearly all "accessories" with "zubehör" #2250

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

Staubgeborener
Copy link
Contributor

@Staubgeborener Staubgeborener commented Nov 23, 2024

Fixed some mistakes.

What is the general consensus? Accessories = Zubehör? Do we use “Child-Bridge” or “Unter-Bridge” in german translation?

and Unter-Bridge with Child-Bridge
@github-actions github-actions bot added the latest Related to Latest Branch label Nov 23, 2024
@bwp91
Copy link
Contributor

bwp91 commented Nov 23, 2024

@Staubgeborener do you want me to merge this or wait to see if it gets any comments to your questions?

@Staubgeborener
Copy link
Contributor Author

I think we should wait, maybe someone else will come up with an opinion on this topic.

@Staubgeborener
Copy link
Contributor Author

Btw, de.json is missing "form.button_restore": "Restore" (which should be "form.button_restore": "Wiederherstellen",), but we have something like "backup.title_restore": "Wiederherstellen" which isn't used anymore. Which leads to this:

image

Before I mess something up here, could you please correct this and bring de.json up to date? Then this PR could be merged.

Oh btw, what even is "History Items" in the network context?

image

@bwp91
Copy link
Contributor

bwp91 commented Dec 8, 2024

@Staubgeborener I updated your fork with the latest changes from the latest branch. You should see the 'missing' entries now.

Also History Items is how many historical data points appear on the network widget (similar config exists for memory and CPU widgets)

@Staubgeborener
Copy link
Contributor Author

ready to merge @bwp91

Copy link
Contributor

@bwp91 bwp91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bwp91 bwp91 merged commit 0f030be into homebridge:latest Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
latest Related to Latest Branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants