Temporarily add maintainers to package.json to handle NPM schema change
#2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwp91
approved these changes
Jun 25, 2024
donavanbecker
added a commit
that referenced
this pull request
Jun 25, 2024
## v4.56.4 (2024-06-25) ### Other Changes - Temporarily add maintainers to package.json to handle NPM schema change (#2080) (@PatrickStankard)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
NPM stopped returning the
maintainerskey from the registry when viewing a versioned package. Is this intentional? Nobody knows. I have a support ticket open with NPM since last Thursday, and the thread on GitHub Communities hasn't seen a response. This change has prevented the Homebridge UI from showing a plugin's author, as well as showing users that there is a Homebridge UI update from within Homebridge.💡 Proposed solution
Unfortunately, users will not see that there are Homebridge UI updates until
maintainersis manually added topackage.json. This key is supposed to be set by NPM themselves, but it appears that you can set it yourself. I copied themaintainersfrom the top-level package metadata here. This change can eventually be reverted if NPM starts settingmaintainersin the versioned package metadata again, or if #2079 is merged, and some amount of time has passed to ensure users have updated their Homebridge UI.