[en] Enable the use of possessives for some nouns #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah. The conflict is because of #2471, which I more or less included here because the PR was listed as draft. I'll sort through and see what I come up with. |
ViViDboarder
force-pushed
the
en-personal-items
branch
from
2669872 to
e5a30d8
Compare
|
This should probably be closed in favor of #2728 |
|
@tetele I could do that, but I split them because they deliver dependent but different changes. I do have another conflict now though 👎 |
Rather than only accepting `the`, many sentences should also accept a possessive like `my`. This doesn't make sense for all instances of `<light>`, so I'll make another refactor commit after this one
ViViDboarder
force-pushed
the
en-personal-items
branch
from
e5a30d8 to
800e336
Compare
|
Conflicts resolved! |
tetele
approved these changes
Dec 19, 2024
mrdarrengriffin
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than only accepting
the, many sentences should also accept a possessive likemy.This doesn't make sense for all instances of
<light>, so I'll make another refactor commit after this one