Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN] Fix apartment typo in sentences-en-_common.yaml #2724

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

justicefreed
Copy link
Contributor

"appartment" should be "apartment"

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @justicefreed

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Dec 6, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 6, 2024 05:07
@justicefreed justicefreed marked this pull request as ready for review December 6, 2024 16:10
Copy link
Contributor

@ViViDboarder ViViDboarder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tetele
Copy link
Contributor

tetele commented Dec 9, 2024

@justicefreed it looks like we were not quick enough with the approval and there are now conflicts. Can you please resolve them?

sentences/en/_common.yaml Outdated Show resolved Hide resolved
sentences/en/_common.yaml Outdated Show resolved Hide resolved
sentences/en/_common.yaml Outdated Show resolved Hide resolved
@justicefreed
Copy link
Contributor Author

Thanks for the catch on the spacing changes for those square brackets - my eyes initially could not see the difference and you beat me to the fix while I was working on it.

@tetele
Copy link
Contributor

tetele commented Dec 12, 2024

I made a mess of it because i am on my phone 😅

@justicefreed
Copy link
Contributor Author

I similarly had done the change in the webui myself and realized I couldn't easily fix it cleanly without cloning it locally. I can force push a consolidated change into a single clean commit if that's preferable.

@justicefreed
Copy link
Contributor Author

Looks like the tests need to be updated as well. Let me take a crack at doing that right now and can consolidate into a single clean commit.

@tetele tetele merged commit d70456a into home-assistant:main Dec 12, 2024
2 checks passed
@tetele
Copy link
Contributor

tetele commented Dec 12, 2024

Thanks @justicefreed and sorry for the long wait

@tetele tetele changed the title Fix apartment typo in sentences-en-_common.yaml [EN] Fix apartment typo in sentences-en-_common.yaml Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants