-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EN] Fix apartment typo in sentences-en-_common.yaml #2724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@justicefreed it looks like we were not quick enough with the approval and there are now conflicts. Can you please resolve them? |
Thanks for the catch on the spacing changes for those square brackets - my eyes initially could not see the difference and you beat me to the fix while I was working on it. |
I made a mess of it because i am on my phone 😅 |
I similarly had done the change in the webui myself and realized I couldn't easily fix it cleanly without cloning it locally. I can force push a consolidated change into a single clean commit if that's preferable. |
Looks like the tests need to be updated as well. Let me take a crack at doing that right now and can consolidate into a single clean commit. |
08657fb
to
5f90150
Compare
Thanks @justicefreed and sorry for the long wait |
"appartment" should be "apartment"