-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NE] Added Initial Support for Nepali Language #2698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hi, we're glad you're here ;) To keep a PR manageable, we break the work into smaller parts. This way, it's clear what has already been completed and what still needs to be done. I suggest including only the files you've already completed in the PR: |
And one more observation:
It's worth starting from the English version and translating that. If you have any questions, feel free to ask! |
@v1k70rk4 Thank you for your suggestions. Based on your advice, I have included only the completed files. Regarding the test, I began by translating the English version and, as per your recommendation, I have removed the domain from the test. |
Until a maintainer approves it, I checked if it would pass the test, and unfortunately, it doesn’t.
This means that: The sentence "बैठकको बत्ती निबाइदेउ न" in its current form does not fit the given template because the verb type "निबाइदेउ" is not covered by the template. The template includes "निबाउनु", but "निबाइदेउ" is a conjugated, imperative form of that verb, which requests the action to be performed. To make this fit, you would need to add the following variations to the template: निबाइदेउ This way, sentences like "बैठकको बत्ती निबाइदेउ न" and similar ones would match the pattern. By the way, how did you get started with the translation? Windows/Linux/Visual Studio Core/Codespace? You can read about how to run tests on your own machine here. You’ll need it if you want to work on the Nepali intents :) |
@v1k70rk4 Thanks again for your input. I will look into it. The specific thing that you mentioned is explicitly defined, and it should have worked. Could you please let me know which test you did so that I can figure out the issue. I am using vscode in linux. |
If |
I have rechecked and perfomed all the tests mentioned in the documents and all of them have passed for HassTurnOn and HassTurnOff. @v1k70rk4 Thank you for helping me out. |
Looks great, thank you! |
Updated _common.yaml, homeassistant_HassTurnOff and homeassistant_HassTurnOn