Fix streams list failing when a stream has WHIP/WebRTC push producers#345
Open
eric-benjamin wants to merge 1 commit into
Open
Fix streams list failing when a stream has WHIP/WebRTC push producers#345eric-benjamin wants to merge 1 commit into
eric-benjamin wants to merge 1 commit into
Conversation
Producers created by pushing into go2rtc (WHIP ingest, WebRTC push) have no "url" key in the /api/streams payload — there is no source URL, the media was pushed. The strict decoder required Producer.url, so a single pushed stream anywhere made the entire streams list undecodable. Make Producer.url optional, matching what go2rtc actually reports. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #344.
Producers created by pushing into go2rtc (WHIP ingest / WebRTC push) have no
"url"key in the/api/streamspayload — there is no source URL, the media was pushed. The strict decoder requiredProducer.url, so a single pushed stream anywhere made the entire streams list undecodable, which in Home Assistant breaks every camera still (async_get_image) and WebRTC offer in the instance while a publisher is connected.Producer.urloptional, matching what go2rtc actually reportstest_streams_getcase for itSame category as #21, which handled
producersitself being null.🤖 Generated with Claude Code