Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hover_mode #1415

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Remove hover_mode #1415

merged 3 commits into from
Sep 20, 2024

Conversation

ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Sep 13, 2024

Closes #1394

  • Removes hover_mode from hvPlot's API (but uses it under the hood) since hvPlot hasn't been released yet

  • Adds tests

  • Improves docs a bit

  • Reorders in alphabetical

@ahuang11 ahuang11 changed the title Refactor hover Remove hover_mode Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (6c96c7e) to head (1aae59f).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1415      +/-   ##
==========================================
+ Coverage   87.39%   88.81%   +1.42%     
==========================================
  Files          50       51       +1     
  Lines        7490     7610     +120     
==========================================
+ Hits         6546     6759     +213     
+ Misses        944      851      -93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximlt maximlt merged commit ac5021b into main Sep 20, 2024
9 checks passed
@maximlt maximlt deleted the refactor_hover branch September 20, 2024 13:51
@maximlt
Copy link
Member

maximlt commented Sep 20, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Touch up hover tools
2 participants