Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple polars explorer #1340

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add simple polars explorer #1340

wants to merge 2 commits into from

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 8, 2024

Fixes #1339

However, I get TypeErrors when moving around the UI. Need to look into if it is directly related to the conversion.

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 87.31%. Comparing base (6c96c7e) to head (23d9f0c).

Files Patch % Lines
hvplot/plotting/core.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
- Coverage   87.39%   87.31%   -0.08%     
==========================================
  Files          50       50              
  Lines        7490     7499       +9     
==========================================
+ Hits         6546     6548       +2     
- Misses        944      951       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1031,7 +1031,9 @@ def ylim(self):
y = self._y
if not isinstance(y, list):
y = [y]
values = [ys for ys in (self._data[y] for y in y) if len(ys)]
values = [
ys for ys in (self._data[y] for y in y) if len(ys) and ys.dtype.kind not in 'OSU'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ys for ys in (self._data[y] for y in y) if len(ys) and ys.dtype.kind not in 'OSU'
ys for ys in (self._data[y] for y in y) if len(ys) and (hasattr(ys, 'dtype') and ys.dtype.kind not in 'OSU')

@maximlt maximlt marked this pull request as draft July 16, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easier to use hvplot.explorer with Polars
1 participant