Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch up hover tools #1394

Open
ahuang11 opened this issue Aug 14, 2024 · 1 comment · May be fixed by #1415
Open

Touch up hover tools #1394

ahuang11 opened this issue Aug 14, 2024 · 1 comment · May be fixed by #1415
Labels
type: enhancement New feature or request

Comments

@ahuang11
Copy link
Collaborator

From Maxime in #1385

I've got a few comments.

Doesn't hover_mode duplicate what is already possible with setting hover to e.g. 'vline'? This was added in https://github.com/holoviz/hvplot/pull/493 but never documented I believe.

Don't think a test is required since it's just adding plot_opts?

Adding tests is pretty much always worth in my opinion, in particular when they're easy to write.

I would suggest alphabetically ordering the new hover_* parameters in the signature, docstring, and doc.

We need to find a way to better document these sorts of options. As it stands, I don't think the docs provide sufficient information for users to leverage these new parameters.
@maximlt
Copy link
Member

maximlt commented Sep 13, 2024

Doesn't hover_mode duplicate what is already possible with setting hover to e.g. 'vline'? This was added in #493 but never documented I believe.

Oh this was not just a docs request, I think we have effectively duplicated the API.

@ahuang11 ahuang11 added type: enhancement New feature or request and removed type: docs labels Sep 13, 2024
@ahuang11 ahuang11 linked a pull request Sep 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants