Fix bug where GetMonthFromJulianDay() would sometimes return the inco…#433
Open
aarebrof wants to merge 1 commit into
Open
Fix bug where GetMonthFromJulianDay() would sometimes return the inco…#433aarebrof wants to merge 1 commit into
aarebrof wants to merge 1 commit into
Conversation
…rrect month in leap years
Author
|
I'm sorry about all the unrelated changes. We have format on save enabled by default, and it does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There appears to be a bug in the
GetMonthFromJulianDay()method in theIrrigationService.cs. It does not take into account whether a year is a leap year, and always assumes that February is 28 days long. This results in first-day of months being considered the incorrect month during leap years.During non-leap years the 60th day of the year is March 1st. But during leap years the 60th day of the year is February 29th. See image below. The same issue persists throughout the year for any month after February.
This PR uses the internal
DateTimeclass to figure out what month a day is, then casts the result directly to theMonthenumerable value.