Skip to content

Conversation

pdaoust
Copy link
Contributor

@pdaoust pdaoust commented Feb 18, 2025

Closes #471 . Covers both local and remote signals.

@pdaoust pdaoust marked this pull request as ready for review February 18, 2025 22:08
@pdaoust pdaoust requested a review from a team February 18, 2025 22:09
@pdaoust pdaoust enabled auto-merge (squash) February 18, 2025 22:15
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. I have a few minor comments but mostly happy. I like how focused this one is on giving code examples and just enough description.

matthme
matthme previously approved these changes Feb 27, 2025
Copy link
Contributor

@matthme matthme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more open suggested change but I can live without it too.

ThetaSinner
ThetaSinner previously approved these changes Feb 27, 2025
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@pdaoust pdaoust merged commit 38df24c into main Feb 27, 2025
6 checks passed
@pdaoust pdaoust deleted the feat/guide/signals branch February 27, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Practical docs for using Signals
3 participants