Go to workspace directly if you provide the name #134

kingshuk00 · 2025-11-13T17:50:51Z

optionally file-system for workspaces with same name in different file-systems

…-system for workspaces with same name in different file-systems

cniethammer

Not 100% sure how high the value is of providing this as users can just do a simple cd $(ws_find NAME)

cniethammer · 2025-11-14T09:16:21Z

bin/ws_go

+  WS_OPT+=" -F "
+  WS_OPT+=`echo ${2}`


Why not simply

Suggested change

WS_OPT+=" -F "

WS_OPT+=`echo ${2}`

WS_OPT+=" -F $2"

cniethammer · 2025-11-14T09:20:52Z

bin/ws_go

+#!/bin/bash
+
+if [ "$#" -eq 0 ]; then
+   echo "Usage: ws_go workspace [file-system]"


usage info should go into separate function usage()

cniethammer · 2025-11-14T09:21:50Z

bin/ws_go

+
+if [ "$#" -eq 0 ]; then
+   echo "Usage: ws_go workspace [file-system]"
+   return


Use exit instead of return

Suggested change

return

exit 1

cniethammer · 2025-11-14T09:22:47Z

bin/ws_go

@@ -0,0 +1,28 @@
+#!/bin/bash
+
+if [ "$#" -eq 0 ]; then


Command line parsing should be improved - looks brittle to me. Also, should (optionally) allow -F as all other ws_* tools

cniethammer · 2025-11-14T09:23:49Z

bin/ws_go

+fi
+
+WS_OPT=
+if [ "$#" -lt 2 ]; then


Command line parsing should be improved - looks brittle to me. Second place.

cniethammer · 2025-11-14T09:25:09Z

bin/ws_go

+
+WS_OPT=
+if [ "$#" -lt 2 ]; then
+   NUMWS=`ws_find $1 | wc -l`


Assign command line arguments to variables - what is $1 here in this scope?

cniethammer · 2025-11-14T09:26:03Z

bin/ws_go

+   return
+fi
+
+WS_OPT=


What do you wanne WS_OPT to be later?

Suggested change

WS_OPT=

WS_OPT=""

or

Suggested change

WS_OPT=

WS_OPT=()

cniethammer · 2025-11-14T09:29:31Z

bin/ws_go

+      NUMFS=`ws_list | grep "^     filesystem name      : " | cut -d ":" -f2 | cut -d" " -f2 | sort -h | uniq | wc -l`
+      FSNAMES=`ws_list | grep "^     filesystem name      : " | cut -d ":" -f2 | cut -d" " -f2 | sort -h | uniq | tr '\n' ' '`


calling ws_list multiple times - use cached output.
The parsing also looks complex, involving many pipes and different commands.

cniethammer · 2025-11-14T09:33:03Z

bin/ws_go

+if ws_list ${WS_OPT} | grep "^id: " | cut -d":" -f2 | cut -d" " -f2 | grep -q $1; then
+  cd `ws_find ${WS_OPT} $1`
+else


why so over complicated. Rel on ws_find and do not call ws_list again...

Suggested change

if ws_list ${WS_OPT} | grep "^id: " | cut -d":" -f2 | cut -d" " -f2 | grep -q $1; then

cd `ws_find ${WS_OPT} $1`

else

ws_dir=$(ws_find ${WS_OPT} $1)

if [[ -d $ws_dir ]]; then

cd "$ws_dir"

else

cniethammer · 2025-11-14T09:33:59Z

bin/ws_go

+  ws_list ${WS_OPT} | grep "^id: " | cut -d":" -f2
+fi


There was obviously an error

Suggested change

ws_list ${WS_OPT} | grep "^id: " | cut -d":" -f2

fi

ws_list ${WS_OPT} | grep "^id: " | cut -d":" -f2

exit 1

fi

holgerBerger · 2025-11-14T10:59:41Z

actually ws_cd might be a better name?
@cniethammer and may be adding bash completion would be cool?

cniethammer · 2025-11-14T11:28:49Z

@holgerBerger bash completion with the currently chosen command line argument ordering will not work - the filesystem has to be an option before the name of a workspace

holgerBerger · 2025-11-20T19:40:53Z

I think the main problem is that should be a shell function and not a shell script, as it can not change parent shells CWD.

cniethammer · 2025-11-21T07:55:08Z

I think the main problem is that should be a shell function and not a shell script, as it can not change parent shells CWD.

I use something rather simple for this in my environment (not taking care of different file systems):

cdws ()
{ 
    local ws_name="$1";
    local ws_dir="$(ws_find "$ws_name")";
    cd $ws_dir
}

Personal opinion: As a user has to include this into his environment (.bashrc, etc.) anyway, I do not see the added value of providing this as part of the installation. A user who can set up his environment should be able to write this small function, as well at this point ...

Go to workspace directly if you provide the name, and optionally file…

7da73a5

…-system for workspaces with same name in different file-systems

cniethammer suggested changes Nov 14, 2025

View reviewed changes

+                 return
+              fi
+              WS_OPT=

		NUMFS=`ws_list \| grep "^ filesystem name : " \| cut -d ":" -f2 \| cut -d" " -f2 \| sort -h \| uniq \| wc -l`
		FSNAMES=`ws_list \| grep "^ filesystem name : " \| cut -d ":" -f2 \| cut -d" " -f2 \| sort -h \| uniq \| tr '\n' ' '`

-if ws_list ${WS_OPT} | grep "^id: " | cut -d":" -f2 | cut -d" " -f2 | grep -q $1; then
-  cd `ws_find ${WS_OPT} $1`
-else
+ws_dir=$(ws_find ${WS_OPT} $1)
+if [[ -d $ws_dir ]]; then
+  cd "$ws_dir"
+else

Go to workspace directly if you provide the name #134

Are you sure you want to change the base?

Go to workspace directly if you provide the name #134

Uh oh!

Conversation

kingshuk00 commented Nov 13, 2025

Uh oh!

cniethammer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

holgerBerger commented Nov 14, 2025

Uh oh!

cniethammer commented Nov 14, 2025

Uh oh!

holgerBerger commented Nov 20, 2025

Uh oh!

cniethammer commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants