Skip to content

Review scripts in bin/ #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mflehmig wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Review scripts in bin/ #108

mflehmig wants to merge 6 commits into from

Conversation

@mflehmig
Copy link
Contributor

@mflehmig mflehmig commented Aug 30, 2024

  • Put import statements together
  • Add comments for better maintainability
  • Fix spelling
  • Print error to stderr

Martin Schroschk added 6 commits August 30, 2024 07:39
holgerBerger
holgerBerger requested changes Sep 5, 2024
View reviewed changes
Copy link
Owner

@holgerBerger holgerBerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the order is intentional, read_python_conf can change the PYTHONPATH,
this is to allow to point pythonpath to python instance wuith yaml reader,
otherwise users using private python instances without yaml module will not be able to use this script

holgerBerger
holgerBerger requested changes Sep 5, 2024
View reviewed changes
Copy link
Owner

@holgerBerger holgerBerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the order is intentional, read_python_conf can change the PYTHONPATH,
this is to allow to point pythonpath to python instance wuith yaml reader,
otherwise users using private python instances without yaml module will not be able to use this script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holgerBerger holgerBerger holgerBerger requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mflehmig @holgerBerger