Conversation
eddgrant
reviewed
Jan 19, 2018
| void 'test prepended bash script'() { | ||
| given: | ||
| JobBuilder jobBuilder = new JobBuilder('test-job', 'test-job-description'). | ||
| withSteps(npmStep("nvm use 4.8.4", ["test"])) |
Contributor
There was a problem hiding this comment.
Will the first command always be something in the form of npm use x.y.x? If so I wonder if it makes sense to add the desired npm version as a parameter in npmStep method? so you could then call it like npmStep("4.8.4", ["test"]), which would then implicitly know to call npm use x.y.x as the first operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to run npm commands without resorting to
shellStep.