Skip to content

Dtr 6375: READY / Accounting Periods I 09: GET Accounting Period Details - #25

Merged
avelx merged 16 commits into
mainfrom
DTR-6375
Aug 13, 2026
Merged

Dtr 6375: READY / Accounting Periods I 09: GET Accounting Period Details#25
avelx merged 16 commits into
mainfrom
DTR-6375

Conversation

@avelx

@avelx avelx commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Blocked: awaiting next PR to be merged:
https://github.com/hmrc/corporation-tax/pull/26 (edited)

image

Local Test A:

./curlauth http://localhost:11202/corporation-tax/accounting-period-details/8754000057/1
As Object ===>:
Object {
    "amountDueForAp": Number(0),
    "crDbCalcFlag": Bool(false),
    "creditInterestAmount": Number(0),
    "debitInterestAmount": Number(0),
    "isApBalanced": Bool(true),
    "latePaymentInterestAmount": Number(0),
    "lpiCalcFlag": Bool(false),
    "repaymentInterestAmount": Number(0),
    "totalDerivedActualInterest": Number(0),
}

As Json ===>: "{'isApBalanced':true,'lpiCalcFlag':false,'crDbCalcFlag':false,'creditInterestAmount':0,'debitInterestAmount':0,'latePaymentInterestAmount':0,'repaymentInterestAmount':0,'totalDerivedActualInterest':0,'amountDueForAp':0}"

Local Test B:

./curlauth http://localhost:11202/corporation-tax/accounting-period-details/2051625586/1
As Object ===>:
Object {
    "amountDueForAp": Number(-199.27),
    "crDbCalcFlag": Bool(false),
    "creditInterestAmount": Number(-199.27),
    "debitInterestAmount": Number(0),
    "isApBalanced": Bool(false),
    "latePaymentInterestAmount": Number(0),
    "lpiCalcFlag": Bool(false),
    "repaymentInterestAmount": Number(0),
    "totalDerivedActualInterest": Number(-398.54),
}

As Json ===>: "{'isApBalanced':false,'lpiCalcFlag':false,'crDbCalcFlag':false,'creditInterestAmount':-199.27,'debitInterestAmount':0,'latePaymentInterestAmount':0,'repaymentInterestAmount':0,'totalDerivedActualInterest':-398.54,'amountDueForAp':-199.27}"

Loca Test C: cross check via Stub data:

./curlauth http://localhost:11202/corporation-tax/accounting-period-details/3/1
As Object ===>:
Object {
    "amountDueForAp": Number(-12.23),
    "crDbCalcFlag": Bool(true),
    "creditInterestAmount": Number(-123.23),
    "debitInterestAmount": Number(-5930.02),
    "isApBalanced": Bool(true),
    "latePaymentInterestAmount": Number(-3231.23),
    "lpiCalcFlag": Bool(true),
    "repaymentInterestAmount": Number(-1.23),
    "totalDerivedActualInterest": Number(-9297.94),
}

As Json ===>: "{'isApBalanced':true,'lpiCalcFlag':true,'crDbCalcFlag':true,'creditInterestAmount':-123.23,'debitInterestAmount':-5930.02,'latePaymentInterestAmount':-3231.23,'repaymentInterestAmount':-1.23,'totalDerivedActualInterest':-9297.94,'amountDueForAp':-12.23}"

avelx added 2 commits August 6, 2026 15:19
feat: create skeleton for AccountingPeriodDetails~ integration work;
feat: create skeleton for AccountingPeriodDetails~ integration work;
@platops-pr-bot

Copy link
Copy Markdown

avelx added 4 commits August 7, 2026 09:29
feat: create skeleton for AccountingPeriodDetails~ integration work;
feat: create skeleton for AccountingPeriodDetails~ integration work;
# Conflicts:
#	app/uk/gov/hmrc/corporationtax/services/PenaltiesService.scala
add logging entry on the service layer;
@platops-pr-bot

Copy link
Copy Markdown

avelx added 7 commits August 10, 2026 11:37
test: create basic test :: AccountingPeriodDetailsServiceSpec
test: fix test failures in :: AccountingPeriodDetailsControllerSpec
test: add extra case in AccountingPeriodDetailsServiceSpec
apply scalafmtAll
test: add AccountingPeriodDetailsConnectorISpec to conver logic in the connector;
test: fix failing test => AccountingPeriodDetailsServiceSpec
apply test/scalafmtAll
@avelx avelx changed the title Dtr 6375: WIP / Accounting Periods I 09: GET Accounting Period Details Dtr 6375: READY / Accounting Periods I 09: GET Accounting Period Details Aug 11, 2026
Comment thread test/uk/gov/hmrc/corporationtax/services/AccountingPeriodDetailsServiceSpec.scala Outdated
refactor: address PR comment
avelx added 2 commits August 13, 2026 11:52
test: address PR comment // add extra UTs  - [2]
apply scalaFmt

@Roshangautam2052 Roshangautam2052 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avelx
avelx merged commit bc5e3dd into main Aug 13, 2026
1 check passed
@avelx
avelx deleted the DTR-6375 branch August 13, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants