Skip to content

DL-19361 decommission ated DES APIs #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Matthew-George-Tyler wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

DL-19361 decommission ated DES APIs #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f831760
DL-19361 decommission ated DES APIs
Matthew-George-Tyler May 29, 2026
e794d80
DL-19361 resolve merge confilcts
Matthew-George-Tyler Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 0 additions & 62 deletions app/connectors/EtmpDetailsConnector.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,50 +95,6 @@ trait EtmpDetailsConnector extends Auditable with Logging {
}
}


def getSubscriptionData(atedReferenceNo: String)(implicit hc: HeaderCarrier): Future[HttpResponse] = {
val getUrl = s"""$serviceUrl/$atedBaseURI/$retrieveSubscriptionData/$atedReferenceNo"""

val timerContext = metrics.startTimer(MetricsEnum.EtmpGetSubscriptionData)
http.get(url"$getUrl").setHeader(createHeaders: _*).execute[HttpResponse].map{ response =>
timerContext.stop()
response.status match {
case OK =>
metrics.incrementSuccessCounter(MetricsEnum.EtmpGetSubscriptionData)
response
case status =>
metrics.incrementFailedCounter(MetricsEnum.EtmpGetSubscriptionData)
logger.warn(s"[EtmpDetailsConnector][getSummaryReturns] - status: $status")
doHeaderEvent("getSubscriptionDataFailedHeaders", response.headers)
doFailedAudit("getSubscriptionDataFailed", getUrl, None, response.body)
response
}
}
}

def updateSubscriptionData(atedReferenceNo: String, updatedData: UpdateEtmpSubscriptionDataRequest)
(implicit hc: HeaderCarrier): Future[HttpResponse] = {
val putUrl = s"""$serviceUrl/$atedBaseURI/$saveSubscriptionData/$atedReferenceNo"""

val timerContext = metrics.startTimer(MetricsEnum.EtmpUpdateSubscriptionData)
val jsonData = Json.toJson(updatedData)
http.put(url"$putUrl").withBody(jsonData).setHeader(createHeaders: _*).execute[HttpResponse].map{ response =>
timerContext.stop()
auditUpdateSubscriptionData(atedReferenceNo, updatedData, response)
response.status match {
case OK =>
metrics.incrementSuccessCounter(MetricsEnum.EtmpUpdateSubscriptionData)
response
case status =>
metrics.incrementFailedCounter(MetricsEnum.EtmpUpdateSubscriptionData)
logger.warn(s"[EtmpDetailsConnector][updateSubscriptionData] - status: $status")
doHeaderEvent("updateSubscriptionDataFailedHeaders", response.headers)
doFailedAudit("updateSubscriptionDataFailed", putUrl, Some(jsonData.toString), response.body)
response
}
}
}

def updateRegistrationDetails(atedReferenceNo: String, safeId: String, updatedData: UpdateRegistrationDetailsRequest)
(implicit hc: HeaderCarrier): Future[HttpResponse] = {
val putUrl = s"""$serviceUrl/$saveRegistrationDetails/$safeId"""
Expand Down Expand Up @@ -168,24 +124,6 @@ trait EtmpDetailsConnector extends Auditable with Logging {
)
}

private def auditUpdateSubscriptionData(atedReferenceNo: String,
updateData: UpdateEtmpSubscriptionDataRequest,
response: HttpResponse)(implicit hc: HeaderCarrier): Unit = {
val eventType = response.status match {
case OK => EventTypes.Succeeded
case _ => EventTypes.Failed
}
sendDataEvent(transactionName = "etmpUpdateSubscription",
detail = Map("txName" -> "etmpUpdateSubscription",
"atedReferenceNo" -> s"$atedReferenceNo",
"agentReferenceNumber" -> s"${updateData.agentReferenceNumber}",
"requestData" -> s"${Json.toJson(updateData)}",
"responseStatus" -> s"${response.status}",
"responseBody" -> s"${response.body}",
"status" -> s"$eventType"))
}


private def auditUpdateRegistrationDetails(atedReferenceNo: String,
safeId: String,
updateData: UpdateRegistrationDetailsRequest,
Expand Down
262 changes: 0 additions & 262 deletions app/connectors/EtmpReturnsConnector.scala
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion app/module/ServiceBindings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ class ServiceBindings extends Module {
playBind(classOf[AuthConnector]).to(classOf[DefaultAuthConnector]),
playBind(classOf[EmailConnector]).to(classOf[EmailConnectorImpl]),
playBind(classOf[EtmpDetailsConnector]).to(classOf[EtmpDetailsConnectorImpl]),
playBind(classOf[EtmpReturnsConnector]).to(classOf[EtmpReturnsConnectorImpl]),
playBind(classOf[HipDetailsConnector]).to(classOf[HipDetailsConnectorImpl]),
playBind(classOf[HipReturnsConnector]).to(classOf[HipReturnsConnectorImpl]),
playBind(classOf[ServiceMetrics]).to(classOf[ServiceMetricsImpl]),
Expand Down
Loading