fix(release): point notarize.macos.ids at the actual build id#14
Merged
Conversation
The previous value "default" matched zero builds, so goreleaser silently skipped signing/notarization with: pipe skipped or partially skipped reason=no darwin binaries The build is named "try" (see builds[].id); ids in notarize.macos expect build ids, not archive ids. v0.1.1 artifacts shipped unsigned as a result. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.1.1 shipped unsigned because `notarize.macos.ids` referenced `default` (the archive id) instead of `try` (the build id). Goreleaser silently skipped signing with `pipe skipped or partially skipped reason=no darwin binaries`.
This PR fixes the id. Next release will actually sign and notarize.
Test plan
🤖 Generated with Claude Code