Skip to content

19682 - Reverted All changes (Credit Company Discount Scheme).#19683

Merged
damithdeshan98 merged 2 commits intodevelopmentfrom
19682-reverted-all-changes-credit-company-discount-scheme
Apr 3, 2026
Merged

19682 - Reverted All changes (Credit Company Discount Scheme).#19683
damithdeshan98 merged 2 commits intodevelopmentfrom
19682-reverted-all-changes-credit-company-discount-scheme

Conversation

@damithdeshan98
Copy link
Copy Markdown
Collaborator

@damithdeshan98 damithdeshan98 commented Apr 3, 2026

Summary by CodeRabbit

  • Removed Features
    • Removed the payment scheme discount management interface for credit companies, including the associated configuration page and backend functionality for creating and editing discount matrices.

Signed-off-by: damithdeshan98 <hkddrajapaksha@gmail.com>
closes #19682
Signed-off-by: damithdeshan98 <hkddrajapaksha@gmail.com>
@damithdeshan98 damithdeshan98 self-assigned this Apr 3, 2026
@damithdeshan98 damithdeshan98 added the Refactor Code restructuring without changing external behavior label Apr 3, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7bcb71e7-7946-4d01-af70-4df0a62aad04

📥 Commits

Reviewing files that changed from the base of the PR and between f7393bc and bf9e907.

📒 Files selected for processing (3)
  • src/main/java/com/divudi/bean/common/NavigationController.java
  • src/main/java/com/divudi/bean/membership/OpdMemberShipDiscountController.java
  • src/main/webapp/admin/pricing/payment_scheme_discount_for_credit_company.xhtml
💤 Files with no reviewable changes (3)
  • src/main/java/com/divudi/bean/common/NavigationController.java
  • src/main/webapp/admin/pricing/payment_scheme_discount_for_credit_company.xhtml
  • src/main/java/com/divudi/bean/membership/OpdMemberShipDiscountController.java

Walkthrough

Removed feature for managing payment scheme discounts for credit companies, including the navigation route, UI page, and associated controller methods for creating, listing, and editing discount entries.

Changes

Cohort / File(s) Summary
Navigation Route
src/main/java/com/divudi/bean/common/NavigationController.java
Removed navigation method navigateToPaymentSchemeDiscountforCreditCompany() that returned the payment scheme discount page route.
Controller Business Logic
src/main/java/com/divudi/bean/membership/OpdMemberShipDiscountController.java
Removed saveSelectedCompanyPaymentScheme() method (payment scheme discount creation), removed fillCompanyPaymentSchemes() method (discount retrieval), and simplified onEdit(PriceMatrix tmp) by removing validation checks for payment scheme, credit company, and discount percentage.
UI View
src/main/webapp/admin/pricing/payment_scheme_discount_for_credit_company.xhtml
Removed entire JSF/Facelets view containing form panels for creating discount matrix entries and editable data table for managing existing entries with update/delete functionality.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: reverting all changes related to the Credit Company Discount Scheme feature, which is confirmed by the removal of navigation method, controller methods, and the entire JSF view.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 19682-reverted-all-changes-credit-company-discount-scheme

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@damithdeshan98 damithdeshan98 merged commit e7897cc into development Apr 3, 2026
3 checks passed
@damithdeshan98 damithdeshan98 deleted the 19682-reverted-all-changes-credit-company-discount-scheme branch April 3, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Code restructuring without changing external behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant