Hotfix: Configurable bill number serial digit count for Ruhunu#19639
Hotfix: Configurable bill number serial digit count for Ruhunu#19639buddhika75 merged 2 commits intoruhunu-prodfrom
Conversation
Replace hardcoded 6-digit serial format (%06d) with configurable "Bill Number Serial Digit Count" option (default: 6). This allows institutions to reduce leading zeros for QuickBooks compatibility (e.g., GRN/RHD/LBK/26/000001 → GRN/RHD/LBK/26/00001). - Add formatSerialNumber() helper in BillNumberGenerator - Register config option in ConfigOptionApplicationController - Add setInteger API endpoint in ConfigResource Closes #19635 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…onventions - Add MAX_SERIAL_DIGITS=12 upper bound in formatSerialNumber() to prevent excessive allocations from misconfigured values - Document hotfix branch naming convention (must end with -hotfix) and feature branch naming patterns in commit-conventions.md Closes #19635 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
%06d) with configurable"Bill Number Serial Digit Count"option (default: 6)setIntegerREST API endpoint to allow changing integer configs via APIProblem
Current:
GRN/RHD/LBK/26/000001(6-digit serial — too many characters for QB)Required:
GRN/RHD/LBK/26/00001(5-digit serial)Post-Deployment Steps
After deploying this hotfix, set the digit count to 5 via API:
Important Notes
Closes #19635
Test plan
🤖 Generated with Claude Code