Update to support RT 4.4 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the sub name to reflect that fact, and update the caller to accept an array. (I don't know how it was working previously.)
Log more information from MessageIdToTickets. Don't log the queue, since we never use it (and the HASH output isn't really helpful).
This fixes a warning about use of undefined $_.
Much of this is just rote work to follow the new Mail Plugin API. The biggest change is that we hook in much earlier in the process, so we don't have a proper ticket object to work on. Instead we work directly on the MIME Message object, including modifying the subject to tie the message to a ticket.
There are pros and cons to both approaches but overall I would rather let a human resolve these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch has a series of changes to update the code to work on RT 4.4. Some changes seem like necessary bugfixes to the original code; then there's one commit with the big API changes; then a couple more aesthetic changes in between. I've done my best to organize commits to make it clear what's what. I hope all the changes are helpful but we could cut some of the last set out of the PR if you prefer.