Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing semicolons #234

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Fix missing semicolons #234

merged 4 commits into from
Nov 13, 2024

Conversation

AnsonYeung
Copy link

Add semicolons in several places in the codegen

This fixes JS codegen on the IR Label(lbl, Break(lbl, true), End())

@LPTK
Copy link
Contributor

LPTK commented Nov 13, 2024

Thanks! But there is no need to add semicolons after things like function definitions and classes. class Foo {} console.log("ok") is valid JS.

BTW, the CI fails due to flakiness for a reason @chengluyu has already fixed in a separate PR.

@LPTK LPTK merged commit 2a3a13c into hkust-taco:hkmc2 Nov 13, 2024
1 check failed
@LPTK LPTK deleted the fix-semicolons branch November 13, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants