Open
Conversation
… wheel builds - moved binaries into pyboolnet (all are distributed OS independently during setup) - setup-time OS-specific binary copying is replaced with runtime resolution using importlib.resources - settings.cfg now only contain absolute and relative paths, relative paths are resolved using importlib.resources - system tools are identified using shutil.which() - repository folder included using package_data instead of manually copying - updated setup.py with respect to these changes All test are passed after building with "python3 -m build" and installing the resultant wheel into a new environment. Caveats: - do not know how this affects the colomoto conda install - only tested on Linux (Ubuntu) Related to - hklarner#124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor install process and executable discovery for PyPi compatible wheel builds, created a PyPi project
Now works:
Changes:
All test are passed after building with "python3 -m build" and installing the resultant wheel into a new environment.
Upload to PyPi:
Build the distribution:
Upload:
Page: https://pypi.org/project/pyboolnet/
I am happy to transfer project ownership at PyPi (I just need a PyPi username).
Long term, a GitHub Action is probably the way forward:
https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/
Caveats:
Related to
Pull request
This pull request is into a new branch "PyPi", to keep it seperate from package functionality, in case it is incompatible and to facilitate contributions from others with a stake in the build/install process.