fix: Add OPCUA Auto-reconnect Retry Backoff Strategy #1304
+269
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marregui
approved these changes
Nov 26, 2025
...emq-edge-module-opcua/src/main/java/com/hivemq/edge/adapters/opcua/OpcUaProtocolAdapter.java
Show resolved
Hide resolved
| } | ||
|
|
||
| final double backoffDelay = | ||
| backoffDelays[index] * (1 + new Random().nextDouble(ConnectionOptions.DEFAULT_RETRY_JITTER)); |
Contributor
There was a problem hiding this comment.
a new random object per retry seems excessive, why not use ThreadLocalRandom.current()
| final long retryIntervalMs = config.getConnectionOptions().retryIntervalMs(); | ||
| // Increment retry attempt counter and calculate backoff delay | ||
| final int attemptCount = consecutiveRetryAttempts.updateAndGet(count -> count + 1); | ||
| long backoffDelayMs ; |
Contributor
There was a problem hiding this comment.
the extra space before the ; killed my day
| @ModuleConfigField(title = "Connection Retry Intervals (milliseconds)", | ||
| description = "Comma-separated list of backoff delays in milliseconds for connection retry attempts. The adapter will use these delays sequentially for each retry attempt, repeating the last value if attempts exceed the list length.", | ||
| defaultValue = DEFAULT_RETRY_INTERVALS) | ||
| String retryIntervalMs, |
Contributor
There was a problem hiding this comment.
this change from Long to String..... radical, I hope it does not break existing config?
| private final @NotNull AtomicReference<ScheduledFuture<?>> healthCheckFuture = new AtomicReference<>(); | ||
|
|
||
| // Retry attempt tracking for exponential backoff | ||
| private final @NotNull AtomicReference<Integer> consecutiveRetryAttempts = new AtomicReference<>(0); |
Contributor
There was a problem hiding this comment.
AtomicInteger is more compact than an AtomicReference to an Integer (and more efficient)
caoccao
force-pushed
the
bugfix/38364-auto-reconnect-backoff-strategy
branch
from
791b828 to
b33caf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hivemq.kanbanize.com/ctrl_board/57/cards/38364/details/