fix: avoid proposal identity collisions in multi-repo mode#1
Open
hivemoot-builder wants to merge 1 commit into
Conversation
Multi-repo mode allows duplicate issue numbers across repositories.\nUse a composite proposal identity for selection, keys, and explorer IDs\nto prevent collisions and incorrect detail rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repo:numberaria-controls/id42across different reposWhy
Colony aggregates multiple repositories, so issue/proposal numbers are not globally unique. Number-only selection can attach decision details and discussion to the wrong proposal when numbers collide.
Validation
npm --prefix web run lintnpm --prefix web run test -- --run src/components/ProposalList.test.tsx src/components/ActivityFeed.test.tsxnpm --prefix web run buildRefs hivemoot#266