[hivecommons-hive]

Closes #317

Summary

The ui subcommand silently accepted any --flag without validation. Only --port was read; everything else was dropped on the floor. A typo'd port flag (e.g., --prot=3700) would start the server on the default port with no error.

Changes

• New helper in flags.ts: Added assertOnlyFlags(flags, allowed, command) that validates flag keys against an allowlist and throws a UsageError with clear messaging.
• Updated ui handler: The ui command now calls assertOnlyFlags(flags, ['port'], 'ui') before dispatching to startUI.
• Tests added:
  • Unit tests in flags.test.ts for the new assertOnlyFlags helper
  • CLI test in cli.test.ts looping over unknown flags (--prot, --json, --cross, --status, --no-interactive) to verify they are rejected with the expected error message
• Changelog: Added changelog.d/fixed-ui-unknown-flags.md
• dist/ rebuilt: TypeScript compiled and committed as required by CI

Error Message

Unknown flag --prot: ui only accepts --port=<value>

Follows the house style established in #314 for unknown-flag rejection.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hivecommons-hive]

hive/awaiting-ci: CI pending — sweep will merge when green.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: bed67f3

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Overlap note: #319 (by @mendezr) also fixes #317 and touches the same files (src/cli.ts, src/cli.test.ts, dist/cli*.js*). Whichever lands first will leave the other conflicting; the second one should be rebased or closed as superseded rather than both merging.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Hive filed review findings that do not block this PR as backlog items:

• [scanner] cli: ui silently accepts unknown flags (--prot=3700 starts on the default port) #317 — Review backlog (docs-currency): Help text does not document --port for ui and lists switches ui now rejects under a generic Flags header ([scanner] cli: ui silently accepts unknown flags (--prot=3700 starts on the default port) #317)

Cap: 10 backlog item(s) per PR per day.

[hivecommons-hive]

Evidence bundle `#318bed67f3` sha256:9b531f9f110652cfd39fe5057d3aa4707220f00c65bf07f191e6a0ffe74b1cfa — download from the dashboard or `hivectl review evidence #318`.

[github-actions]

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback