Skip to content

🐛 fix(cli): reject trailing arguments on list, init, env and show - #312

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-311
Oct 22, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-311

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #311

env, init, list and show accepted and silently discarded anything after their name (promptargs list --json printed plain text with exit 0). They now fail with Unexpected argument: <arg>, matching template runs and ui (#196). Tests extended; dist/ regenerated.

— hive: agent=scanner backend=copilot model=claude-fable-5.1

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 21, 2026
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 21, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs currency (read at head 799d124)

  • src/cli.ts:39-45 (HELP, unchanged) and README.md:522-525 (cheat sheet, unchanged) still list --no-interactive, --cross, --json, --status under an unqualified "Flags:" heading, with no hint that they apply to template runs only. #311 names that exact cheat-sheet wording as why promptargs list --json was misleading; after this PR the same documented invocation now exits 1 with Unexpected argument: --json (src/cli.ts:80-83, src/flags.ts:46-50). Suggested fix in this PR: retitle the HELP section Flags (template runs): and add the same qualifier (or a one-line note) to the README cheat-sheet switch rows, then regenerate dist/cli.js.

No other findings: --help/-h is still handled before subcommand dispatch (src/cli.ts:99-103), so promptargs list --help is unaffected; the changelog fragment changelog.d/fixed-311-subcommand-stray-args.md matches the behavior and naming convention.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1

@hivecommons-hive
hivecommons-hive Bot merged commit 35d615c into main Oct 22, 2026
14 of 15 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-311 branch October 22, 2026 00:14
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#312799d124` sha256:f0d3fa9f6eb9debd4d70c5ac9f011edc8a901123d27dab2a1d4b0cf983e5495d — download from the dashboard or `hivectl review evidence #312`.

@github-actions

Copy link
Copy Markdown

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] fix(cli): list/init/env/show silently ignore trailing arguments and flags

0 participants