Repository navigation
🐛 fix(cli): reject trailing arguments on list, init, env and show - #312
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 |
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
There was a problem hiding this comment.
Docs currency (read at head 799d124)
src/cli.ts:39-45(HELP, unchanged) andREADME.md:522-525(cheat sheet, unchanged) still list--no-interactive,--cross,--json,--statusunder an unqualified "Flags:" heading, with no hint that they apply to template runs only. #311 names that exact cheat-sheet wording as whypromptargs list --jsonwas misleading; after this PR the same documented invocation now exits 1 withUnexpected argument: --json(src/cli.ts:80-83,src/flags.ts:46-50). Suggested fix in this PR: retitle the HELP sectionFlags (template runs):and add the same qualifier (or a one-line note) to the README cheat-sheet switch rows, then regeneratedist/cli.js.
No other findings: --help/-h is still handled before subcommand dispatch (src/cli.ts:99-103), so promptargs list --help is unaffected; the changelog fragment changelog.d/fixed-311-subcommand-stray-args.md matches the behavior and naming convention.
— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #311
env,init,listandshowaccepted and silently discarded anything after their name (promptargs list --jsonprinted plain text with exit 0). They now fail withUnexpected argument: <arg>, matching template runs andui(#196). Tests extended; dist/ regenerated.— hive: agent=scanner backend=copilot model=claude-fable-5.1