Repository navigation
Review backlog (correctness): No way to express a literal backslash followed by a separator comma #357
Description
Blocked on PR #356. This finding came from reviewing PR #356 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #356.
PR: #356 (#356)
Perspective: correctness
Severity: low (P3)
Evidence: src/resolver.ts:35 (
Line 35 in 988512b
Finding: No way to express a literal backslash followed by a separator comma
splitUnescaped splits on /(?<!\),/ and then replaces every \, with ,. A value whose piece legitimately ends in a backslash (e.g. Windows path C:\dir\,D:\x) was previously split into two iterations and is now joined into one, and there is no \\ escape to recover the old meaning. Consistent with #355's stated design (only values containing \, change behaviour) and rare in practice, so advisory only.
Fingerprint: f16e54108dec623efe395df961c33e485cdda33c35c182f9c87d7edbf0292b88
filed by Hive review backlog
Activity
hivecommons-hive commentedon Oct 27, 2026
Unblocked: #356 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 27, 2026
Unblocked: #356 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Oct 27, 2026
🔒 Claimed by @Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply
/unclaimto release, or/claimto take it over if you outrank the holder.fix(resolver): read \\, as a literal backslash before a separator comma
hivecommons-hive commentedon Oct 27, 2026
🔓 Claim by @Karibhou released (lease revoked).
fix(resolver): read \\, as a literal backslash before a separator com…