Repository navigation
fix(attach): include --cli-args in the --dangerous restart hint for an existing session - #371
Conversation
…n existing session Closes #370 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/S
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
hivecommons-hive
Bot
added
author/hive
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks correct to me.
Read src/attach.ts at 81fef53: the existing-session hint (attach.ts:369-373) now builds buildCliCommand(cliCmd, opts.cliArgs) and then appends the word-split danger flag — the same construction the new-session path uses at attach.ts:345-353, so the two hints can no longer drift. The old call buildCliCommand(cliCmd, dangerFlag) already word-split the flag, so the only behavioural change is that --cli-args is no longer dropped, which is exactly what #370 asks for. dangerEnv prefixing is unchanged.
Ran node --test test/attach-orchestration.test.js on the PR head after tsc: 41/41 pass, including the new case. Changelog fragment name matches the fixed-<issue>.md convention.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
hivecommons-hive
Bot
removed
role/trusted
The --dangerous restart hint on an existing session now includes --cli-args in the suggested restart command, matching the behavior of the new-session path.
Closes #370
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88