[hivecommons-hive]

Closes #360

pluk attach --dangerous silently passed nothing for --cli=gemini and --cli=aider because DANGEROUS_FLAGS had no entry for them and the skip was only logged under --verbose.

• add gemini: --yolo and aider: --yes-always
• print a real Warning: line (not verbose-gated) when a CLI has no known auto-approve flag
• README --dangerous row updated to match
• test pins every bundled/builtin CLI to a DANGEROUS_FLAGS entry so the gap cannot reopen

Tests

Not run locally; CI is the verdict.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hivecommons-hive]

hive/awaiting-ci: CI pending — sweep will merge when green.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Hive filed review findings that do not block this PR as backlog items:

• [scanner] attach: --dangerous silently no-ops for --cli=gemini and --cli=aider (no DANGEROUS_FLAGS mapping) #360 (folded into an existing issue) — Review backlog (correctness): Existing-session path stays silent for a CLI with no DANGEROUS_FLAGS entry ([scanner] attach: --dangerous silently no-ops for --cli=gemini and --cli=aider (no DANGEROUS_FLAGS mapping) #360)

Cap: 10 backlog item(s) per PR per day.

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Read the diff against the PR tree. Looks correct to me.

• src/attach.ts:164-174 — DANGEROUS_FLAGS gains gemini: '--yolo' and aider: '--yes-always'; both are the real auto-approve flags for those CLIs. They are single tokens, so the splitShellWords(...).map(shellQuote) path at attach.ts:343 yields exactly 'gemini' '--yolo' / 'aider' '--yes-always', which is what the new test at test/attach-orchestration.test.js:234-245 pins.
• attach.ts:346 — the skip is now an unconditional console.error('Warning: …') instead of the --verbose-gated log(...). Only reached on the new-session branch (attach.ts:331-348), same as before, so re-attach behaviour is unchanged.
• test/cli-support-matrix.test.js:134-139 — the new drift guard iterates BUILTIN_PATTERNS ∪ bundled, both already imported/computed at lines 17/44 of that file, so it cannot silently pass on an empty set. Combined with the existing README↔DANGEROUS_FLAGS row check at :117, the README update is enforced too.
• changelog.d/fixed-360.md follows the <category>-<issue>.md naming.

Body matches the diff (Closes #360); test (22/24/26) and verify are green. No findings.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Evidence bundle `#361fd310ac` sha256:b4340a8b74b336d317e403ce15a261f72cd0c7e1957c4b0d573f0f4f6eb267e6 — download from the dashboard or `hivectl review evidence #361`.

[github-actions]

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback