Skip to content

Review backlog (style): Stale assertion message in support-matrix test #364

Closed
#363
Closed
Review backlog (style): Stale assertion message in support-matrix test#364
#363
Labels
agent/reviewerCreated by Hive for agent-filed issue provenancehelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Description

@hivecommons-hive
hivecommons-hive
bot
opened on Oct 24, 2026

Filed from an out-of-scope finding in the Hive review of PR #363.

PR: #363 (#363)
Perspective: style
Severity: info (P3)
Evidence: test/cli-support-matrix.test.js:136 (

pluk/test/cli-support-matrix.test.js

Line 136 in 5bb5a72

for (const cli of new Set([...Object.keys(BUILTIN_PATTERNS), ...bundled])) {
)
Finding: Stale assertion message in support-matrix test

The merged-map test's failure message still reads 'DANGEROUS_FLAGS has no flag for …' although the test now also accepts DANGEROUS_ENV entries; minor readability drift.

Fingerprint: d379633ffc39f51f7b6a9264ebd5313a7a66241e2b7110b4c3176ebdb226eb1a

filed by Hive review backlog

Activity

  1. hivecommons-hive
    added
    agent/reviewerCreated by Hive for agent-filed issue provenance
    on Oct 24, 2026
  2. github-actions
    added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 24, 2026
  3. hivecommons-hive
    added
    hive/claimed-by-scanner
    stage/020-claimedClaimed by the scanner or a relay contributor
    on Oct 24, 2026

  4. hivecommons-hive commented on Oct 24, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Oct 24, 2026 – with hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  5. hivecommons-hive commented on Oct 24, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Oct 24, 2026 – with hivecommons-hive
    ContributorAuthor

    Consolidated finding. This was filed as a separate issue; it references exactly the same files as this one (test/cli-support-matrix.test.js), so it was folded in here instead. Address it in the same PR as this issue — two PRs editing the same files would conflict.

    Review backlog (intent-alignment): cli-support-matrix 'launchable via CLI_COMMANDS' test not extended to DANGEROUS_ENV

    Filed from an out-of-scope finding in the Hive review of PR #363.

    PR: #363 (#363)
    Perspective: intent-alignment
    Severity: info (P3)
    Evidence: test/cli-support-matrix.test.js:69 (

    pluk/test/cli-support-matrix.test.js

    Line 69 in 1223fd5

    for (const cli of recordKeys(attachSource, 'DANGEROUS_FLAGS')) {
    )
    Finding: cli-support-matrix 'launchable via CLI_COMMANDS' test not extended to DANGEROUS_ENV

    test/cli-support-matrix.test.js:67-72 still iterates only recordKeys(attachSource, 'DANGEROUS_FLAGS'); a future DANGEROUS_ENV entry for a CLI missing from CLI_COMMANDS would not be caught. Goose is in CLI_COMMANDS today so there is no functional impact; advisory only.

    Fingerprint: b0794525698cec5b039a78f65578a09a73e60afc871506dfc662c6498ea56344

    filed by Hive review backlog

    Folded finding. This was filed as a separate issue, but 1 open agent-filed issue (plus 2 closed as completed in the last 14 days) already cite test/cli-support-matrix.test.js, so it was folded into the oldest of them instead of opening another. Treat this issue as the tracker for that component: prefer one structural fix that covers every folded variant over a PR per variant.

    Review backlog (docs-currency): README-pinning test messages still name only DANGEROUS_FLAGS

    Filed from an out-of-scope finding in the Hive review of PR #363.

    PR: #363 (#363)
    Perspective: docs-currency
    Severity: info (P3)
    Evidence: test/cli-support-matrix.test.js:130 (

    pluk/test/cli-support-matrix.test.js

    Line 130 in 1223fd5

    'README --dangerous row should list exactly the CLIs DANGEROUS_FLAGS knows',
    )
    Finding: README-pinning test messages still name only DANGEROUS_FLAGS

    test/cli-support-matrix.test.js:124 and :130 assertion messages read '(attach.ts DANGEROUS_FLAGS)' / 'exactly the CLIs DANGEROUS_FLAGS knows' although the test now merges DANGEROUS_ENV; same drift class as #364 but on the sibling test. Readability only; no behavior impact.

    Fingerprint: 2260e23147d72661e0541cd226b929e5de83dfac842a9a4e863070ffd7379904

    filed by Hive review backlog

  6. hivecommons-hive commented on Oct 24, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Oct 24, 2026 – with hivecommons-hive
    ContributorAuthor

    Additional finding (folded in — same file, possibly a different problem). Raised in the Hive review of PR #363 (#363) and folded into this issue because it cites test/cli-support-matrix.test.js, which this issue already covers. It may describe a different problem from this issue's own; address it together with this issue or file it separately before closing.

    Review backlog (intent-alignment): cli-support-matrix 'launchable via CLI_COMMANDS' test not extended to DANGEROUS_ENV

    • cli-support-matrix 'launchable via CLI_COMMANDS' test not extended to DANGEROUS_ENV (test/cli-support-matrix.test.js:69)

    Perspective: intent-alignment
    Severity: info (P3)
    Evidence: test/cli-support-matrix.test.js:69 (

    pluk/test/cli-support-matrix.test.js

    Line 69 in 1223fd5

    for (const cli of recordKeys(attachSource, 'DANGEROUS_FLAGS')) {
    )
    Finding: cli-support-matrix 'launchable via CLI_COMMANDS' test not extended to DANGEROUS_ENV

    test/cli-support-matrix.test.js:67-72 still iterates only recordKeys(attachSource, 'DANGEROUS_FLAGS'); a future DANGEROUS_ENV entry for a CLI missing from CLI_COMMANDS would not be caught. Goose is in CLI_COMMANDS today so there is no functional impact; advisory only.

    Fingerprint: b0794525698cec5b039a78f65578a09a73e60afc871506dfc662c6498ea56344

    filed by Hive review backlog

  7. hivecommons-hive commented on Oct 24, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Oct 24, 2026 – with hivecommons-hive
    ContributorAuthor

    Additional finding (folded in — same file, possibly a different problem). Raised in the Hive review of PR #363 (#363) and folded into this issue because it cites test/cli-support-matrix.test.js, which this issue already covers. It may describe a different problem from this issue's own; address it together with this issue or file it separately before closing.

    Review backlog (docs-currency): README-pinning test messages still name only DANGEROUS_FLAGS

    • README-pinning test messages still name only DANGEROUS_FLAGS (test/cli-support-matrix.test.js:130)

    Perspective: docs-currency
    Severity: info (P3)
    Evidence: test/cli-support-matrix.test.js:130 (

    pluk/test/cli-support-matrix.test.js

    Line 130 in 1223fd5

    'README --dangerous row should list exactly the CLIs DANGEROUS_FLAGS knows',
    )
    Finding: README-pinning test messages still name only DANGEROUS_FLAGS

    test/cli-support-matrix.test.js:124 and :130 assertion messages read '(attach.ts DANGEROUS_FLAGS)' / 'exactly the CLIs DANGEROUS_FLAGS knows' although the test now merges DANGEROUS_ENV; same drift class as #364 but on the sibling test. Readability only; no behavior impact.

    Fingerprint: 2260e23147d72661e0541cd226b929e5de83dfac842a9a4e863070ffd7379904

    filed by Hive review backlog

  8. hivecommons-hive
    added
    stage/040-covered-by-prAn open PR covers this issue
    and removed
    stage/020-claimedClaimed by the scanner or a relay contributor
    on Oct 24, 2026
  9. hivecommons-hive
    closed this as completedin #363on Oct 24, 2026
  10. hivecommons-hive
    removed
    stage/040-covered-by-prAn open PR covers this issue
    hive/claimed-by-scanner
    on Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerCreated by Hive for agent-filed issue provenancehelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions