Skip to content

Conversation

@hitomipupil
Copy link
Owner

No description provided.

@hitomipupil hitomipupil requested a review from puemos December 12, 2024 15:08
@hitomipupil hitomipupil self-assigned this Dec 12, 2024
@puemos
Copy link
Collaborator

puemos commented Dec 12, 2024

I really like the new design!

Just two things:

Item Image
Bug: When the page first loads, the inputs are blank. image
Enhancement: Maybe you can align the inputs and captions? image

@hitomipupil
Copy link
Owner Author

  • Filled the inputs(color, column and row) with values
  • Aligned the labels and the inputs
  • Added hover effect on the reset button

@puemos
Copy link
Collaborator

puemos commented Dec 13, 2024

Fantastic, one last thing: it might be better to change from "click" to "mousedown" to make the experience more snappy :)

https://github.com/hitomipupil/pixel-editor/blob/updateCSS/src/index.js#L61

@hitomipupil
Copy link
Owner Author

  • changed event type from click to mousedown for grids. yes it is more intuitive :)

@hitomipupil hitomipupil merged commit 008a72a into main Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants