fix: calculate burnchain reward reorgs correctly #2355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://stacks-blockchain-gdobbf746-hirosystems.vercel.app 🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
I currently am testing the migration and how long it takes to finish in dev. The writer pod gets killed after an hour like you said, but I think it's because Istio is cutting off the connection rather than postgres. Upon restart of the writer, it crashes again saying a migration is already running, and I've confirmed this via PGHero. So it seems like Istio killing the connection and causing the writer to crash may be ok, since the migration continues. I'll continue monitoring its progress, this will likely be a upgrade deployed next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Burnchain reward re-orgs were being calculated incorrectly based on old Stacks 2.x logic that no longer applies after 3.x. This was causing some rewards to disappear from our endpoints after being marked as non-canonical.