-
Notifications
You must be signed in to change notification settings - Fork 1
feat: worker thread pool #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelcr
approved these changes
Apr 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Will be super useful for C2.0
…toolkit into feat/worker-thread-pool2 # Conflicts: # src/helpers/index.ts
hirosystems-release-bot bot
added a commit
that referenced
this pull request
Jun 2, 2025
## [1.9.0](v1.8.0...v1.9.0) (2025-06-02) ### Features * onceWhen function ([#43](#43)) ([840b2f1](840b2f1)) * onceWhen function ([#43](#43)) ([#44](#44)) ([4013b38](4013b38)) * worker thread pool ([#41](#41)) ([16c9616](16c9616)) ### Bug Fixes * git info check should not throw when debugging ([#39](#39)) ([66f44d5](66f44d5))
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a utility for using
node:worker_modules
with a type-safe interface. Additionally, it implements:Example usage
Example of a worker module
First, define a worker module in a new file. This module is initialized in each worker thread, in an isolated environment. See the nodejs docs for more information.
The module must export two properties:
processTask
function that can be sync or async and can take any amount of argumentsworkerModule
constant that is assigned to the global module variable for this fileThese two properties can either be exported by themselves, or there can be a single default export object, e.g. a file named
example-worker.ts
:or
Example manager usage
Once a worker module is implemented, for example the above
example-worker.ts
module, then it can be used by theWorkerThreadManager
utility implemented in this PR.For example, here's a
main.ts
file usingWorkerThreadManager
to parallelize the code fromexample-worker.ts
using multiple logical CPUs:Notes:
WorkerThreadManager
is type-checked to ensure that the the module provided (in this caseexample-worker.ts
) implements the correct interface, andWorkerThreadManager.exec
function mirrors theprocessTask
function type from the given worker module.processTask
is a simple "multiply" function, however, in real-world usage this can be a CPU-intensive function (for example complex binary deserialization or cryptographic code), and it can also be a async/Promise.