感想を追記 #336
Open
感想を追記 #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimon49
reviewed
May 31, 2020
Comment on lines
+70
to
+75
| <p class="impression">マージされる前に再コミットしておきます</p> | ||
|
|
||
| <p class="impression">具体的なハウツーを簡潔に書かれた記事だと思いました</p> | ||
|
|
||
| <p class="impression"><h1>自分で自分にプルリクエスト！？</h1></p> | ||
|
|
There was a problem hiding this comment.
@UKONNsoft Pull Requestありがとうございます。
感想の中に <h1> の見出しが入ってしまうと表示が崩れてしまいます。この要素は取って欲しいです。
また、 <p class="impression"> でマークアップされた件数をカウントして、寄せられた件数の総数として表示していることから、できれば1つにまとめて頂きたいです。
http://hirocaster.github.io/wdpress69/
raimon49
requested changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
いまさらですが・・・