Add Dumbbell & Tilemap examples, optional module-load timeout, and expanded tests/docs #418
+555
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KacperMadej @karolkolodziej thanks in advance for the review ;) |
karolkolodziej
requested changes
Sep 22, 2025
|
|
||
| // Create the chart as soon as we can | ||
| private readonly chart = computed(() => { | ||
| private readonly chart = computed(async () => { |
There was a problem hiding this comment.
IMO, this change (some methods/properties being async) should be listed as a breaking change and described in the readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the Highcharts integration by:
Adding Dumbbell and Tilemap examples (requested due to reported issues).
Refs: #417 && #415
Some users hit intermittent “module not attached yet” scenarios—especially with heavier or multiple modules (e.g., map, tilemap, highcharts-more, dumbbell, pattern-fill, gantt). The optional timeout provides a safe buffer so the service only publishes the Highcharts instance once all modules have finished augmenting it. The added examples make it easier for the community to reproduce and verify.
Introducing an optional timeout in the loading pipeline to accommodate modules that need a few extra milliseconds before augmenting the Highcharts namespace.
Expanding test coverage to validate that modules are properly loaded.
Updating the README with examples and troubleshooting notes.
Breaking Changes
None. The timeout is optional and disabled by default. Existing integrations continue to work as before.