Skip to content

Added firstName and lastName#4

Open
jselesan wants to merge 3 commits into
high54:masterfrom
jselesan:master
Open

Added firstName and lastName#4
jselesan wants to merge 3 commits into
high54:masterfrom
jselesan:master

Conversation

@jselesan

@jselesan jselesan commented Sep 3, 2018

Copy link
Copy Markdown

I found this module very useful, but in my current project I need to distinct first name and last name. This pull request contains the changes needed to get that data from the user profile

user.email = response.email;
user.token = response.token;
user.firstName = response.first_name;
user.lastName = response.lastName;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be last_name, at least for v3.1 api.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll fix it

@jselesan

Copy link
Copy Markdown
Author

Fixed!

@jselesan

Copy link
Copy Markdown
Author

Could you please merge this pull request? It's is very useful for me

@MikeDabrowski

MikeDabrowski commented Nov 13, 2018

Copy link
Copy Markdown

If its very useful you can always add this manually to your project as I did. I improved your idea by adding a way to specify which fields you want to get from ie. fbApi. Take a look here, maybe it will help you.
https://github.com/MikeDabrowski/angular-6-social-login/commits/library-custom-options

@jselesan

Copy link
Copy Markdown
Author

Yes, sure, but I didn't succeed in installing the package from github...

npm i https://github.com/MikeDabrowski/angular-6-social-login.git

does not work

@MikeDabrowski

Copy link
Copy Markdown

That won't work. By manual install I mean download zip, unzip it and move to your project. I wanted to publish my mod as npm package but failed at some point. But I can assure you, manually copying it to your project will work.

@jselesan

jselesan commented Nov 13, 2018 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants