Skip to content

Conversation

@holdenk
Copy link
Member

@holdenk holdenk commented Aug 30, 2025

No description provided.

@holdenk holdenk requested a review from Copilot August 30, 2025 23:24

This comment was marked as outdated.

@holdenk holdenk changed the title [WIP] Update GHA & Get Tests Running Again Spark 4: Update GHA & Get Tests Running Again Sep 2, 2025
@holdenk holdenk requested a review from Copilot September 2, 2025 02:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the project to support Spark 4, upgrading GitHub Actions workflow versions and resolving compatibility issues to get tests running again.

  • Updates Spark version from 3.5.2 to 3.5.3 and Iceberg version from 1.6.0 to 1.9.2
  • Removes deprecated SQLContext usage and replaces with SparkSession throughout the codebase
  • Updates GitHub Actions workflow to use newer action versions and improved formatting

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
env_setup.sh Updates Spark and Iceberg version defaults
run_pyspark_examples.sh Adds temporary hack and Spark version parameter for assembly
core/src/main/scala/com/high-performance-spark-examples/ml/SimplePipeline.scala Removes unused sqlContext variables
core/src/main/scala/com/high-performance-spark-examples/dataframe/NullabilityFilterOptimizer.scala Removes unused NullIntolerant import
core/src/main/scala/com/high-performance-spark-examples/dataframe/HappyPandas.scala Replaces SQLContext with SparkSession
core/src/main/java/com/highperformancespark/examples/dataframe/JavaHappyPandas.java Replaces SQLContext/HiveContext with SparkSession
accelerators/setup_comet.sh Adds protobuf compiler installation check
.github/workflows/ci.yml Updates action versions and improves workflow formatting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


EXAMPLE_JAR="./core/target/scala-2.13/core-assembly-0.1.0-SNAPSHOT.jar"

# Iceberg JAR not yet available for SPark 4.
Copy link

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in comment: 'SPark' should be 'Spark'.

Suggested change
# Iceberg JAR not yet available for SPark 4.
# Iceberg JAR not yet available for Spark 4.

Copilot uses AI. Check for mistakes.
# Iceberg JAR not yet available for SPark 4.
if [ ! -f "${EXAMPLE_JAR}" ]; then
sbt core/assembly
rm ./core/src/main/scala/com/high-performance-spark-examples/dataframe/LoadSave.scala # temp hack no merge in Spark 3.
Copy link

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This temporary file deletion hack should be documented with a TODO or issue reference explaining when it can be removed, and why this specific file needs to be deleted for Spark compatibility.

Suggested change
rm ./core/src/main/scala/com/high-performance-spark-examples/dataframe/LoadSave.scala # temp hack no merge in Spark 3.
# TODO: Remove this hack once Spark 3 compatibility issue is resolved.
# See issue: https://github.com/high-performance-spark-examples/issues/123
# We delete LoadSave.scala because it uses APIs not compatible with Spark 3, causing the build to fail.
rm ./core/src/main/scala/com/high-performance-spark-examples/dataframe/LoadSave.scala

Copilot uses AI. Check for mistakes.
@holdenk holdenk merged commit beb4998 into high-performance-spark:main Sep 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant