moved to kafka 4 and cp 7.9.0 #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Confluent Platform images from version 7.8.1 to 7.9.0 and moves to Kafka 4, along with adjusting test code for the new configuration and updating the Kafka client poll method. The key changes include:
- Upgrading container image tags (application and init) across Kubernetes YAML definitions.
- Updating test classes (both JSON and String producers) to use a new Partitioner in the MockProducer initialization.
- Modifying the Kafka client to use Duration for consumer polling and removing an unused authorizer.
Reviewed Changes
Copilot reviewed 45 out of 59 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| confluent-for-kubernetes/k8s/confluent-platform.yaml | Upgraded Kafka and init container image versions; note inconsistent volume capacity unit. |
| confluent-avro-specific-record/src/test/java/org/hifly/kafka/demo/producer/serializer/json/JsonProducerMockTest.java | Updated test setup to use a custom Partitioner for the MockProducer. |
| confluent-avro-specific-record/src/test/java/org/hifly/kafka/demo/producer/serializer/string/StringProducerMockTest.java | Updated test setup to use a custom Partitioner for the MockProducer. |
| confluent-for-kubernetes/k8s/confluent-platform-reducted.yaml | Upgraded Kafka and init container image versions. |
| kafka-clients-graalvm/src/main/java/org/hifly/kafka/demo/KafkaClient.java | Changed consumer.poll to use Duration for polling. |
| authorizers/src/main/java/org/hifly/kafka/authorizer/DummyAuthorizer.java | Removed the DummyAuthorizer implementation. |
Files not reviewed (14)
- .env: Language not supported
- README.adoc: Language not supported
- admin-client/pom.xml: Language not supported
- authorizers/config/consumer.properties: Language not supported
- authorizers/config/producer.properties: Language not supported
- authorizers/docker-compose.yml: Language not supported
- authorizers/pom.xml: Language not supported
- authorizers/src/main/resources/consumer.properties: Language not supported
- authorizers/src/main/resources/producer.properties: Language not supported
- claim-check/pom.xml: Language not supported
- confluent-avro-hierarchy-event/pom.xml: Language not supported
- confluent-avro-multi-event/pom.xml: Language not supported
- confluent-avro-specific-record/pom.xml: Language not supported
- kafka-consumer/pom.xml: Language not supported
Comments suppressed due to low confidence (1)
confluent-for-kubernetes/k8s/confluent-platform.yaml:8
- The YAML file sets the volume capacity as '1G' while a similar file uses '1Gi'. Consider standardizing the volume capacity unit to avoid potential misconfiguration.
dataVolumeCapacity: 1G
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.