Refactor Proto Generator and Deprecate Methods in SDK #2436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored the update_protobufs.py script into a ProtoGenerator class for improved organization and readability. - Added detailed comments and error handling for loading premade templates and executing commands. - Updated methods for generating Java files from protobufs, including generate_RequestType, generate_Status, generate_FeeDataType, and generate_FreezeType. - Deprecated several methods in AbstractTokenTransferTransaction, AccountAllowanceAdjustTransaction, and AccountAllowanceApproveTransaction with clear instructions for replacements. - Enhanced documentation for deprecated fields and methods in AccountBalance to guide users towards alternatives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist