Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GRPC endpoint to get segments #323

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Add GRPC endpoint to get segments #323

merged 3 commits into from
Jan 20, 2025

Conversation

khoa165
Copy link
Collaborator

@khoa165 khoa165 commented Jan 20, 2025

Changes

  • Add new GRPC endpoint to protobuf definition for getting collection segments
  • Add a function in collection module to expose segment names
  • Add a function in index_server to implement the endpoint for getting collection segments

Motivation

Per #225, this is the first step towards manual compaction for segments feature

Screenshot

Screenshot 2025-01-20 at 11 55 40 AM

@khoa165 khoa165 requested a review from hicder January 20, 2025 17:00
@khoa165 khoa165 merged commit 1ad3259 into master Jan 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hicder hicder hicder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khoa165 @hicder